Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Azure EventHub fallbacks correctly to default checkpointer #6096

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: Azure EventHub fallbacks correctly to default checkpointer #6096

merged 3 commits into from
Sep 25, 2024
+2 −3

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Aug 20, 2024 •
edited
Loading

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes to #6084

@JorTurFer
fix: Azure EventHub shows checkpointer error properly
4776d09 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner August 20, 2024 22:31
@JorTurFer
Copy link
Member Author

JorTurFer commented Aug 20, 2024 •
edited by github-actions bot
Loading

/run-e2e event_hub
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) August 20, 2024 22:37
zroubalik
zroubalik reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly are we doing here?

@JorTurFer
Copy link
Member Author

f**k, I don't remember it 🤦
Let me check it again

@JorTurFer
.
9b8be48 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

I've updated the PR (there were missing changes). When we migrate to the new azure SDK from the old SDKs, the error handling changed and we don't need (and we don't have to) unwrap the error and it produces a bug -> #6084

@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 10, 2024 •
edited by github-actions bot
Loading

/run-e2e event_hub
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Sep 10, 2024
Open
@JorTurFer JorTurFer changed the title fix: Azure EventHub shows checkpointer error properly fix: Azure EventHub exposes checkpointer error properly Sep 10, 2024
@JorTurFer
Merge branch 'main' into fix-unwrap
aa041e2 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title fix: Azure EventHub exposes checkpointer error properly fix: Azure EventHub fallbacks correctly to the default checkpointer Sep 24, 2024
@JorTurFer JorTurFer changed the title fix: Azure EventHub fallbacks correctly to the default checkpointer fix: Azure EventHub fallbacks correctly to default checkpointer Sep 24, 2024
@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 24, 2024 •
edited by github-actions bot
Loading

/run-e2e event_hub
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

PTAL @zroubalik @wozniakjan

wozniakjan
wozniakjan approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JorTurFer JorTurFer merged commit e582fd4 into kedacore:main Sep 25, 2024
17 of 18 checks passed
@JorTurFer JorTurFer deleted the fix-unwrap branch September 25, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorTurFer @zroubalik @wozniakjan