fix: Azure EventHub fallbacks correctly to default checkpointer #6096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
|
/run-e2e event_hub |
zroubalik
reviewed
Sep 10, 2024
|
f**k, I don't remember it 🤦 |
|
I've updated the PR (there were missing changes). When we migrate to the new azure SDK from the old SDKs, the error handling changed and we don't need (and we don't have to) unwrap the error and it produces a bug -> #6084 |
|
/run-e2e event_hub |
JorTurFer
changed the title
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
JorTurFer
changed the title
JorTurFer
changed the title
|
/run-e2e event_hub |
|
PTAL @zroubalik @wozniakjan |
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Oct 7, 2024
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes to #6084