Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Apache v2.0 License #658

Closed
caniszczyk opened this issue Mar 9, 2020 · 11 comments · Fixed by #661
Closed

Move to Apache v2.0 License #658

caniszczyk opened this issue Mar 9, 2020 · 11 comments · Fixed by #661
Assignees
Labels
cncf All issues related to CNCF

Comments

@caniszczyk
Copy link

Since KEDA is becoming a CNCF Sandbox project, it will have to adhere to the CNCF IP Policy:
https://github.com/cncf/foundation/blob/master/charter.md#11-ip-policy

Apache v2.0 License + DCO is the easiest and lowest path forward imho.

@caniszczyk caniszczyk added needs-discussion feature-request All issues for new features that have not been committed to labels Mar 9, 2020
@tomkerkhove tomkerkhove added cncf All issues related to CNCF and removed feature-request All issues for new features that have not been committed to needs-discussion labels Mar 10, 2020
@tomkerkhove
Copy link
Member

License has been changed, feel free to do a sanity check @caniszczyk.

Once approved, I'll make same changes to other repos in our org (other than samples, if ok)

@tomkerkhove tomkerkhove reopened this Mar 11, 2020
@caniszczyk
Copy link
Author

LGTM thanks, please enforce across all other repos

@tomkerkhove
Copy link
Member

I'll reopen it to keep track of it!

@tomkerkhove tomkerkhove reopened this Mar 13, 2020
tomkerkhove added a commit to kedacore/sample-azure-functions-on-ocp4 that referenced this issue Mar 14, 2020
tomkerkhove added a commit to kedacore/sample-dotnet-worker-servicebus-queue that referenced this issue Mar 14, 2020
tomkerkhove added a commit to tomkerkhove/sample-hello-world-azure-functions that referenced this issue Mar 14, 2020
tomkerkhove added a commit to kedacore/keda-external-scaler-azure-durable-functions that referenced this issue Mar 14, 2020
tomkerkhove added a commit to kedacore/samples that referenced this issue Mar 14, 2020
tomkerkhove added a commit to tomkerkhove/sample-typescript-kafka-azure-function that referenced this issue Mar 14, 2020
tomkerkhove added a commit to tomkerkhove/keda-olm-operator that referenced this issue Mar 14, 2020
tomkerkhove added a commit to tomkerkhove/sample-javascript-eventhub-azure-function that referenced this issue Mar 14, 2020
@turbaszek
Copy link
Contributor

turbaszek commented Mar 19, 2020

@tomkerkhove maybe we should add a pre-commit check to assert licenses are present? That's what we do in Airflow. It's always good to automate boring stuff :)

There's a nice framework to manage pre-commit hooks: https://pre-commit.com and here's list of check we do in Airflow: https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml

I'm personally using pre-commits for linting go.

@zroubalik
Copy link
Member

@nuclearpinguin the pre-commit check is supposed to check that the licence is not removed in that particullar commit? Or what is the specific usecase?

@turbaszek
Copy link
Contributor

turbaszek commented Mar 19, 2020

@zroubalik it checks if license is present, if not it adds the missing license. In the end, the developer doesn't have to care about the license as long as the pre-commit is installed :)

It's also easy to run all checks on CI using pre-commit run --all-files . I can open a poc PR so we can discuss it

Edit: and the pre-commit check license on per file basis. In ASF project the license is required in every file.

@zroubalik
Copy link
Member

@nuclearpinguin gotcha! PR is a great idea

@tomkerkhove
Copy link
Member

You are more talking about license mentioned in all source code files rather than the repo license itself, right?

@caniszczyk Do we have to add licenses to all source code files? If not, I'd say we are good without to reduce the "noise".

@turbaszek
Copy link
Contributor

You are more talking about license mentioned in all source code files rather than the repo license itself, right?

Yup (edit in my last comment). I do not know if CNCF requires them. If not, no need for such automation.

tomkerkhove added a commit to kedacore/sample-javascript-eventhub-azure-function that referenced this issue Mar 19, 2020
tomkerkhove added a commit to kedacore/sample-typescript-kafka-azure-function that referenced this issue Mar 19, 2020
tomkerkhove added a commit to kedacore/dashboard that referenced this issue Mar 19, 2020
tomkerkhove added a commit to kedacore/sample-hello-world-azure-functions that referenced this issue Mar 19, 2020
@caniszczyk
Copy link
Author

https://github.com/cncf/foundation/blob/master/copyright-notices.md

@tomkerkhove
Copy link
Member

Based on that I think we are good with only DCO & our updated license.

Closing.

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
Co-authored-by: Yarden Siboni <yasiboni@microsoft.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf All issues related to CNCF
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants