Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling 1->N doesn't work for ScaledObject with missing deploymentName label #708

Closed
zroubalik opened this issue Mar 30, 2020 · 0 comments · Fixed by #709
Closed

Scaling 1->N doesn't work for ScaledObject with missing deploymentName label #708

zroubalik opened this issue Mar 30, 2020 · 0 comments · Fixed by #709
Labels
bug Something isn't working

Comments

@zroubalik
Copy link
Member

A regression was brought by this PR, if user creates ScaledObject without deploymentName label scaling 1->N doesn't work, because the metrics server doesn't know how to look up the correct ScaledObject.

KEDA operator should add this label automatically, if it is missing.

Specifications

  • KEDA Version: 1.13
  • Kubernetes Version: v16.2
  • Scaler(s): all
@zroubalik zroubalik added the bug Something isn't working label Mar 30, 2020
@zroubalik zroubalik mentioned this issue Mar 30, 2020
Merged
@zroubalik zroubalik mentioned this issue Apr 6, 2020
Closed
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
@chalin @tomkerkhove
Fix deploy 404s (kedacore#708)
7550dc0 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add deploymentName label if needed zroubalik/keda
1 participant
@zroubalik