Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose KEDA Metrics Api Server Prometheus Metrics #823

Closed
tbickford opened this issue May 18, 2020 · 5 comments
Closed

Expose KEDA Metrics Api Server Prometheus Metrics #823

tbickford opened this issue May 18, 2020 · 5 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion operations

Comments

@tbickford
Copy link
Contributor

It would be nice if the Metrics API Server also exposed Prometheus Metrics similar to how the KEDA Operator does.

Use-Case

There are really two use cases for exposing some metrics:

  1. Debugging or viewing what the actual metric value is. The HPA only provides the average value of the metric. It would be useful to see the actual value of the metric when determining how the HPA is computing the target average.

  2. Error Monitoring/Reporting without using logs. When there are issues getting the external metric it would be good to see if this is occurring and how many times this has happened.

Specification

Possible metrics -

  • keda_metrics_apiserver_external_metric{scaledObjectNamespace="prom-test",scaledObjectName="prom-scaled-object",name="prometheus"} 10

  • keda_metrics_apiserver_external_metric_error_count{scaledObjectNamespace="prom-test",scaledObjectName="prom-scaled-object",name="prometheus"} 2

  • keda_metrics_apiserver_total_error_count 2

@tbickford tbickford added feature-request All issues for new features that have not been committed to needs-discussion labels May 18, 2020
@tomkerkhove
Copy link
Member

In terms of general metrics we can use existing exporters to get CPU, et all so we can skip those, right?

@tbickford
Copy link
Contributor Author

@tomkerkhove Good question. I believe those could be skipped as Resource-based metrics can be scraped through other means (ie cAdvisor).

@zroubalik
Copy link
Member

@ckuduvalli FYI as you were interested in Scaling related Prometheus metrics. Take a look on the draft as well

@tomkerkhove
Copy link
Member

tomkerkhove commented Aug 17, 2020

We can close this one I think, right?

Think we only need it in https://github.com/kedacore/keda/blob/v2/CHANGELOG.md#v200

@zroubalik
Copy link
Member

Fixed in #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion operations
Projects
None yet
Development

No branches or pull requests

3 participants