Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Azure Key Vault support in TriggerAuthentication #900

Closed
tomkerkhove opened this issue Jun 25, 2020 · 15 comments · Fixed by #2727
Closed

Provide Azure Key Vault support in TriggerAuthentication #900

tomkerkhove opened this issue Jun 25, 2020 · 15 comments · Fixed by #2727
Assignees
@v-shenoy
Labels
auth feature All issues for new features that have been committed to help wanted Looking for support from community

Comments

@tomkerkhove
Copy link
Member

Provide Azure Key Vault support in TriggerAuthentication to pull secrets from.
@tomkerkhove tomkerkhove added feature-request All issues for new features that have not been committed to needs-discussion labels Jun 25, 2020
@alexandery
Copy link

+1 on this.

@jeffhollan jeffhollan mentioned this issue Feb 20, 2021
Closed
@jeffhollan jeffhollan added the help wanted Looking for support from community label Feb 20, 2021
@SebastianSchuetze
Copy link

How would the general approach be? I am a bit confused on how I would need to start on it if I wanted to contribute.

@tomkerkhove
Copy link
Member Author

We provide a contribution guide on https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md but I'd ask @zroubalik @ahmelsayed @JorTurFer for more in-depth guidance.

We should, however, document how to add a new authentication source.

@tomkerkhove tomkerkhove mentioned this issue Nov 22, 2021
Open
@tomkerkhove
Copy link
Member Author

This should directly talk to Azure Key Vault as Azure Key Vault Provider for Secrets Store CSI Driver is another scenario to cover that should already work today.

@stale
Copy link

stale bot commented Jan 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 31, 2022
@tomkerkhove tomkerkhove added the feature All issues for new features that have been committed to label Jan 31, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jan 31, 2022
@tomkerkhove tomkerkhove removed the feature-request All issues for new features that have not been committed to label Jan 31, 2022
@SebastianSchuetze
Copy link

still want this feature and I think it should come!

@tomkerkhove
Copy link
Member Author

We are happy to review PRs ;)

@SebastianSchuetze
Copy link

I know. just wanted to keep this open for now 😜

@tomkerkhove tomkerkhove moved this to Backlog in Roadmap - KEDA Core Feb 10, 2022
@v-shenoy
Copy link
Contributor

I plan on taking this up. @tomkerkhove

@tomkerkhove
Copy link
Member Author

Thank you!

@tomkerkhove tomkerkhove moved this from To Do to In Progress in Roadmap - KEDA Core Feb 17, 2022
@v-shenoy
Copy link
Contributor

v-shenoy commented Mar 4, 2022

Got a bit busy with some other work, working on this. Commenting so that the issue doesn't get marked as stale.

@tomkerkhove
Copy link
Member Author

No worries, issue won't get stale and take your time - Thanks for the update!

@v-shenoy
Copy link
Contributor

v-shenoy commented Mar 7, 2022 •
edited
Loading

Could you provide me some more resources I could read up on for adding authentication sources? @tomkerkhove

@tomkerkhove
Copy link
Member Author

We don't have any docs on adding auth providers I think, but we should add this.

Or am I mistaken @JorTurFer @zroubalik ?

@zroubalik
Copy link
Member

Nope, it's in the code though 😅

@v-shenoy v-shenoy mentioned this issue Mar 9, 2022
Merged
5 tasks
@tomkerkhove tomkerkhove moved this from In Progress to In Review in Roadmap - KEDA Core Mar 11, 2022
@tomkerkhove tomkerkhove mentioned this issue Mar 14, 2022
Merged
5 tasks
Repository owner moved this from In Review to Ready To Ship in Roadmap - KEDA Core Mar 16, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
@tomkerkhove
chore: Add @chalin as code owner from CNCF (kedacore#900)
5910350
@manjurshaikh1988 manjurshaikh1988 mentioned this issue Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v-shenoy v-shenoy

Labels
auth feature All issues for new features that have been committed to help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide support for Azure Key Vault in TriggerAuthentication. v-shenoy/keda
6 participants
@zroubalik @alexandery @tomkerkhove @jeffhollan @SebastianSchuetze @v-shenoy