Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1056 Make pkg/scalers revive compatible #1088

Merged
merged 11 commits into from
Sep 9, 2020
Merged

1056 Make pkg/scalers revive compatible #1088

merged 11 commits into from
Sep 9, 2020

Conversation

kashifsoofi
Copy link
Contributor

@kashifsoofi kashifsoofi commented Sep 4, 2020 •
edited
Loading

Fixed revive suggestions under pkg/scaler folder.

Checklist

Fixes #1056

Please let me know if i missed something.

@turbaszek
Copy link
Contributor

turbaszek commented Sep 5, 2020 •
edited
Loading

@kashifsoofi can you please take a look at CI errors? It seems that some names were not changes everywhere across the project and you should run go-fmt on your changes. make gofmt should do

Also please remove fixed files from exclude list in .pre-commit-config.yaml so the CI checks are run on those files.

@kashifsoofi
Copy link
Contributor Author

@kashifsoofi can you please take a look at CI errors? It seems that some names were not changes everywhere across the project and you should run go-fmt on your changes. make gofmt should do

Also please remove fixed files from exclude list in .pre-commit-config.yaml so the CI checks are run on those files.

Thanks will update.

turbaszek
turbaszek approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@turbaszek turbaszek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌🏼

@tomkerkhove
Copy link
Member

Where can I find this PR because it looks like it's not open yet or am I missing something?

Make sure to only update v2.0 and include the samples.

@kashifsoofi kashifsoofi mentioned this pull request Sep 7, 2020
Closed
@turbaszek turbaszek mentioned this pull request Sep 7, 2020
Merged
4 tasks
@kashifsoofi
1056 Make pkg/scalers golint compatible
da5efc1 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1058 Rebase on v2
1f89b3d 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1056 Renamed types and constants
8fbac23 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1056 Removed unused import
a811f63 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1056 import pq as its required package
af3e8b6 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1056 Reorder imports
6180a70 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1056 Added comment as suggested
6f06096 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1056 Removed fixed files from exclude list, fixed redis_scaler_test.go
6abd526 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1056 Fixed go vet error
2c2c8f6 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1056 Revert restApiTemplate name change, disable revive on field
ec9bb89 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@kashifsoofi
1056 Disable var-naming check to correctly format struct fields
798148a 
Signed-off-by: Kashif Jamal Soofi <kashif.soofi+git@gmail.com>
@turbaszek
Copy link
Contributor

@tomkerkhove @zroubalik can you take a look?

@kashifsoofi kashifsoofi changed the title 1056 Make pkg/scalers golint compatible 1056 Make pkg/scalers revive compatible Sep 8, 2020
zroubalik
zroubalik approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 544cdf2 into kedacore:v2 Sep 9, 2020
@kashifsoofi kashifsoofi deleted the 1056-make-pkg-scalers-golint-compatible branch September 10, 2020 09:07
This was referenced Sep 14, 2020
Closed
Merged
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
@gauron99 @zroubalik
cpu/mem scalers can scale to zero (kedacore#1088)
fff3e34 
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: David Fridrich <49119790+gauron99@users.noreply.github.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@turbaszek turbaszek turbaszek approved these changes

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make pkg/scalers revive compatible
4 participants
@kashifsoofi @turbaszek @tomkerkhove @zroubalik