Introduce GitHub Code Scanning #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
tomkerkhove
force-pushed
the
tomkerkhove-patch-1
branch
from
7241d96 to
2eef55f
Compare
|
Have you been thinking in incorporating this under https://github.com/kedacore/keda/blob/v2/.github/workflows/pr-validation.yml ? |
|
Honestly, no. Just wanted to keep it separate but happy to merge if you prefer! |
|
The amount of checks is huge 😄 |
|
I'll move it! |
YOu should have a look at how many I have here 😂 tomkerkhove/promitor#1265 |
No way man 😄 I got your point, sometimes the break down is good. But for the stuff you have added, the |
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce GitHub Code Scanning.
I'm not using Snyk here since this is built-in but if we want to use that instead (given it will do all our container scanning) I'm happy to change it.