Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the address of a variable cannot be nil #1148

Merged
merged 1 commit into from
Sep 14, 2020
Merged

the address of a variable cannot be nil #1148

merged 1 commit into from
Sep 14, 2020

Conversation

silenceper
Copy link
Contributor

Signed-off-by: silenceper silenceper@gmail.com

Provide a description of what has been changed

Checklist

Fixes #1147

zroubalik
zroubalik requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! minor nit on the naming

@silenceper
the address of a variable cannot be nil
1ae249c 
Signed-off-by: silenceper <silenceper@gmail.com>
zroubalik
zroubalik approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@silenceper silenceper mentioned this pull request Sep 14, 2020
Closed
@zroubalik zroubalik merged commit 3a99b77 into kedacore:v2 Sep 14, 2020
@silenceper silenceper deleted the staticcheck branch September 14, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the address of a variable cannot be nil
2 participants
@silenceper @zroubalik