enable gofmt,golint and fix lint errors #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: silenceper <silenceper@gmail.com>
25 tasks
|
How does this works with this: https://github.com/kedacore/keda/blob/v2/Makefile#L199-L215 |
|
|
@silenceper ok, would you mind changing the Makefile accordingly, please? |
Signed-off-by: silenceper <silenceper@gmail.com>
|
PTAL |
ahmelsayed
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
I'm not I understand why the previous one was missing those files. from the help, it seems that go fmt runs gofmt -l -w. Maybe it's the -s for simplify code? Anyway, this looks good to me. Thanks @silenceper again.
|
Yes, I add -s to gofmt,otherwise golangci will fail to detect |
silenceper
added a commit
to silenceper/keda
that referenced
this pull request
Oct 1, 2020
* enable gofmt,golint and fix lint errors Signed-off-by: silenceper <silenceper@gmail.com> * fix Makefile: change to golangci Signed-off-by: silenceper <silenceper@gmail.com>
SpiritZhou
pushed a commit
to SpiritZhou/keda
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io> Signed-off-by: Eldarrin <mortxbox@live.com> Signed-off-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: silenceper silenceper@gmail.com
enable gofmt,golint for golangci, and fix lint errors.
gofmt file
pkg/scalers/azure/azure_monitor_test.goChecklist
Fixes #