Adding auth trigger to pubsub #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
RealHarshThakur
requested review from
ahmelsayed and
zroubalik
as code owners
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
ahmelsayed
approved these changes
Oct 26, 2020
|
LGTM. Thanks @harshthakur9030! |
|
Would you mind updating our docs on https://github.com/kedacore/keda-docs/blob/master/content/docs/2.0/scalers/gcp-pub-sub.md as well please? |
tomkerkhove
suggested changes
Oct 27, 2020
There was a problem hiding this comment.
Can you update the changelog please?
https://github.com/kedacore/keda/blob/v2/CHANGELOG.md
zroubalik
approved these changes
Oct 27, 2020
| // incorrect credentials | ||
| {map[string]string{"subscriptionName": "mysubscription", "subscriptionSize": "7", "credentialsFromEnv": "WRONG_CREDS"}, true}, | ||
| {nil, map[string]string{"subscriptionName": "mysubscription", "subscriptionSize": "7", "credentialsFromEnv": "WRONG_CREDS"}, false}, |
There was a problem hiding this comment.
As you mentioned in the slack, this should be revised, we don't have to keep this test case, as it is the same as the one on line 25
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
|
PTAL @zroubalik @tomkerkhove ! Did the changes asked. Here's the doc PR: kedacore/keda-docs#293 |
tomkerkhove
approved these changes
Oct 28, 2020
zroubalik
approved these changes
Oct 29, 2020
arschles
pushed a commit
to arschles/keda
that referenced
this pull request
Dec 1, 2020
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com> Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Thakur harshthakur9030@gmail.com
Provide a description of what has been changed
Checklist
Relates to #1273