prometheus scaler: handle errors from Prometheus server #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a typo or some other error in query, prometheus server returns non-2xx response, which is being ignored silently. This checks for response code and returns appropriate error Signed-off-by: Suresh Kumar <sureshkumar.pp@gmail.com>
tomkerkhove
approved these changes
Jan 11, 2021
zroubalik
reviewed
Jan 11, 2021
zroubalik
approved these changes
Jan 11, 2021
|
@surki would you mind adding this to the Changelog (Improvements section)? |
Signed-off-by: Suresh Kumar <sureshkumar.pp@gmail.com>
surki
force-pushed
the
prometheus-scaler-log-errors
branch
from
7ebe6d7
to
01abfbc
Compare
Done, thanks. |
ahmelsayed
approved these changes
Jan 12, 2021
|
Thanks @surki for your contribution |
ycabrer
pushed a commit
to ycabrer/keda
that referenced
this pull request
Mar 1, 2021
* prometheus scaler: handle errors from Prometheus server When there is a typo or some other error in query, prometheus server returns non-2xx response, which is being ignored silently. This checks for response code and returns appropriate error Signed-off-by: Suresh Kumar <sureshkumar.pp@gmail.com> * Update changelog Signed-off-by: Suresh Kumar <sureshkumar.pp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suresh Kumar sureshkumar.pp@gmail.com
When there is a typo or some other error in prometheus query, prometheus server returns
non-2xx response, which is being ignored silently. This checks for response
code and returns appropriate error
Checklist