Add openapi spec

[surki]

Signed-off-by: Suresh Kumar Ponnusamy suresh.ponnusamy@freshworks.com

Add OpenAPI spec support, without which k8s apiserver log is flooded with errors/retries.
This follows similar upstream changes done here

Checklist

• Commits are signed with Developer Certificate of Origin (DCO)
• Changelog has been updated

Fixes #1503

[surki]

@zroubalik looks like we move pkg/generated this away, generate again and compare. Should I move pkg/generated/openapi into adapter/generated or somewhere else?

Or should I move the openapi spec generation logic into hack/update-codegen.sh? (not sure the role of make generate)

[zroubalik]

Thanks for doing this!

@zroubalik looks like we move pkg/generated this away, generate again and compare. Should I move pkg/generated/openapi into adapter/generated or somewhere else?

Or should I move the openapi spec generation logic into hack/update-codegen.sh? (not sure the role of make generate)

I'd move it into adapter/generated.

[zroubalik]

@surki you can ignore the failing static check (I will address that in a separate PR), just please add exclude-rule for the staticcheck linter for the pkg/scalers/stackdriver_client.go in https://github.com/kedacore/keda/blob/main/.golangci.yml#L50 and please add there a comment with explanation and link to this PR.

[surki]

@zroubalik looks like the CI / Validate PR (pull_request) failure is due to this . We appear to be using tools.go from main branch, so it is not pulling new dependency that is introduced in this PR.

[zroubalik]

@zroubalik looks like the CI / Validate PR (pull_request) failure is due to this . We appear to be using tools.go from main branch, so it is not pulling new dependency that is introduced in this PR.

@surki Sorry I am not sure I fully understand, that line in pr-validation.yml is about the container that's being used to do the build, you can see the Dockerfile for this container here: https://github.com/kedacore/keda/blob/main/tools/build-tools.Dockerfile

[surki]

@zroubalik looks like the CI / Validate PR (pull_request) failure is due to this . We appear to be using tools.go from main branch, so it is not pulling new dependency that is introduced in this PR.

@surki Sorry I am not sure I fully understand, that line in pr-validation.yml is about the container that's being used to do the build, you can see the Dockerfile for this container here: https://github.com/kedacore/keda/blob/main/tools/build-tools.Dockerfile

The new dependency we have added here in tools.go is not being pulled in (but looks like controller-gen etc are already pulled in as part of Docker image).

I could think of two options:

• Add a step in workflow file to sync go modules. Something like

@@ -23,6 +23,9 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-go-
 
+      - name: Go modules sync
+        run: go mod tidy
+
       - name: Verify Generated clientset is up to date
         run: make clientset-verify

• Update the build-tools.Dockerfile to install openapi-gen

I would suggest to go with first option. are you okay if I do that?

[zroubalik]

@surki gotcha. Syncing the go.mod sounds like a good idea!

[zroubalik]

LGTM