Support multi dimension values and configurable metricValues on AWS Cloudwatch Scaler #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasMatos0
force-pushed
the
cloudwatch-multidimension
branch
from
ef0084f
to
8c46e76
Compare
|
My name is wrong, pls when its possible make the correction =D , just to not forget. |
ahmelsayed
approved these changes
Jan 20, 2021
ahmelsayed
reviewed
Jan 20, 2021
tomkerkhove
changed the title
zroubalik
reviewed
Jan 21, 2021
There was a problem hiding this comment.
Looking good, could you please open PR with this change in https://github.com/kedacore/keda-docs? And add this to the Changelog (Improvements section)
JonasMatos0
force-pushed
the
cloudwatch-multidimension
branch
6 times, most recently
from
fceb33e
to
54772a9
Compare
…loudwatch scaler Signed-off-by: Jonas Matos <js.matos@sidi.org.br> Signed-off-by: Thiago Teodoro Rodrigues <t.teodoro@sidi.org.br>
JonasMatos0
force-pushed
the
cloudwatch-multidimension
branch
from
54772a9
to
16e9391
Compare
|
We can merge this one, once the docs PR si ready: kedacore/keda-docs#352 |
ycabrer
pushed a commit
to ycabrer/keda
that referenced
this pull request
Mar 1, 2021
…loudwatch scaler (kedacore#1517) Signed-off-by: Jonas Matos <js.matos@sidi.org.br> Co-authored-by: Jonas Matos js.matos@sidi.org.br Co-authored-by: Thiago Teodoro Rodrigues t.teodoro@sidi.org.br
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…loudwatch Scaler
Co-authored-by: Jonas Matos js.matos@sidi.org.br
Co-authored-by: Thiago Teodoro Rodrigues t.teodoro@sidi.org.br
Provide a description of what has been changed
Checklist
Fixes #