Fix unnecessary HPA updates when Resource based Trigger is used #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
tomkerkhove
approved these changes
Jan 27, 2021
ycabrer
pushed a commit
to ycabrer/keda
that referenced
this pull request
Mar 1, 2021
…core#1541) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Rodolfodc
pushed a commit
to sidilabs/keda
that referenced
this pull request
Mar 11, 2021
…core#1541) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
Under some conditions (when there was Resource based Trigger with some other Trigger defined in ScaledObject in a specific order) KEDA operator was frequently updating HPA, even when it wasn't needed. See the issue for details
Checklist
Fixes #1531