Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add container port for Prometheus on operator YAML #1562

Merged
merged 3 commits into from
Feb 11, 2021
Merged

feat: Add container port for Prometheus on operator YAML #1562

merged 3 commits into from
Feb 11, 2021

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Feb 3, 2021 •
edited
Loading

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Add container port for Prometheus on operator YAML exposed by operator SDK.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Relates to kedacore/charts#118

@tomkerkhove
feat: Add container port for Prometheus on operator YAML
d339ecc 
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove
Update changelog
1d49137 
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove mentioned this pull request Feb 3, 2021
Merged
@tomkerkhove
Merge remote-tracking branch 'upstream/main' into operator-port-prome…
cb675c1 
…theus

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@ahmelsayed ahmelsayed merged commit 6db006a into kedacore:main Feb 11, 2021
ycabrer pushed a commit to ycabrer/keda that referenced this pull request Mar 1, 2021
@tomkerkhove @ycabrer
feat: Add container port for Prometheus on operator YAML (kedacore#1562)
fc95e1c 
* feat: Add container port for Prometheus on operator YAML

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Update changelog

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Rodolfodc pushed a commit to sidilabs/keda that referenced this pull request Mar 11, 2021
@tomkerkhove @Rodolfodc
feat: Add container port for Prometheus on operator YAML (kedacore#1562)
e266bcd 
* feat: Add container port for Prometheus on operator YAML

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Update changelog

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed ahmelsayed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomkerkhove @ahmelsayed @zroubalik