Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka: provide new option to enable scaling past partition count #1684

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Kafka: provide new option to enable scaling past partition count #1684

merged 2 commits into from
Mar 26, 2021

Conversation

lionelvillard
Copy link
Contributor

@lionelvillard lionelvillard commented Mar 17, 2021 •
edited
Loading

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Relates to #1683

@lionelvillard
Copy link
Contributor Author

Here an initial proposal. If accepted, I'll add some tests and documentation.

@zroubalik zroubalik requested a review from tomkerkhove March 22, 2021 09:05
@tomkerkhove
Copy link
Member

Would you mind updating the docs please?

@tomkerkhove tomkerkhove removed their request for review March 22, 2021 09:22
@lionelvillard lionelvillard mentioned this pull request Mar 25, 2021
Merged
@lionelvillard
Copy link
Contributor Author

Doc PR: kedacore/keda-docs#407

@lionelvillard
provide new option to enable scaling past partition count
5f8ed08 
Signed-off-by: Lionel Villard <villard@us.ibm.com>
@lionelvillard lionelvillard force-pushed the kafka-no-partition-check branch from d62cc6f to 5f8ed08 Compare March 25, 2021 17:46
zroubalik
zroubalik reviewed Mar 26, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you please add a test to check whether the value is parsed correctly?

@zroubalik zroubalik changed the title provide new option to enable scaling past partition count Kafka: provide new option to enable scaling past partition count Mar 26, 2021
@lionelvillard
Copy link
Contributor Author

Looking good, could you please add a test to check whether the value is parsed correctly?

Isn't this good enough: https://github.com/kedacore/keda/pull/1684/files#diff-74937abdfe4bcd7bfa4682524e865761aa8aa4b824a4fc2f6fe03bdea3a94e14R34 ?

@zroubalik
Copy link
Member

Looking good, could you please add a test to check whether the value is parsed correctly?

Isn't this good enough: https://github.com/kedacore/keda/pull/1684/files#diff-74937abdfe4bcd7bfa4682524e865761aa8aa4b824a4fc2f6fe03bdea3a94e14R34 ?

Would be nice to add entry in here: https://github.com/kedacore/keda/pull/1684/files#diff-74937abdfe4bcd7bfa4682524e865761aa8aa4b824a4fc2f6fe03bdea3a94e14L46
Nothing complex is needed.

@lionelvillard
add additional test
c9d1550 
Signed-off-by: Lionel Villard <villard@us.ibm.com>
zroubalik
zroubalik approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 6833a81 into kedacore:main Mar 26, 2021
@tomkerkhove tomkerkhove mentioned this pull request May 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionelvillard @tomkerkhove @zroubalik