Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't send .git in docker context #1753

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Apr 22, 2021

  • Context is lighter when running on remote docker server
  • Image was not reproducible
  • Azure ACR build ignore .git by default

Provide a description of what has been changed

Add parameters to Makefile and build-arg to Dockefile to pass git commit and version (only things require .git).

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Guilhem Lettron <guilhem@barpilot.io>

Context is lighter when running on remote docker server
Image was not reproducible
Azure ACR build ignore .git by default
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice improvement.

BTW do you build you own KEDA?

@guilhem
Copy link
Contributor Author

guilhem commented Apr 22, 2021

@zroubalik as we are using it with azure pipeline, not yet released, we had to build it from source.

@zroubalik zroubalik merged commit 69b69ba into kedacore:main Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants