Apache artemis origin header needed #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the origin header making it configurable Signed-off-by: Bernard Chesnoy <bernard.chesnoy@gmail.com>
Signed-off-by: Bernard Chesnoy <bernard.chesnoy@gmail.com>
zroubalik
approved these changes
May 11, 2021
There was a problem hiding this comment.
Looking good, thanks @bonky42
I am just curious, is this something that is needed for newer versions of Artemis and it wasn't needed before? If that's the case, does the code introduced in this PR work with the older versions of Artemis?
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encounter a problem while using apache artemis (last version), it complains that the header Origin is null. It seems now, unless you remove cors protection there is a need to add this header.
Content of the patch:
Signed-off-by: Bernard Chesnoy bernard.chesnoy@gmail.com