Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Selenium Grid scaler #1971

Merged
merged 7 commits into from
Jul 31, 2021

Conversation

prashanth-volvocars
Copy link
Contributor

@prashanth-volvocars prashanth-volvocars commented Jul 21, 2021

Signed-off-by: prashanth rprashanth27@gmail.com

Added a new scaler to scale selenium grid browser nodes based on the requests pending in queue. This will query the selenium grid based on the url that user provides and determine the metric based on the provided browser name.

Checklist

Fixes #871

Signed-off-by: prashanth <rprashanth27@gmail.com>
@zroubalik zroubalik changed the title Added new scaler for selenium grid Add Selenium Grid scaler Jul 22, 2021
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! Looking good, there are a couple of minor nits and some linting problems. Could you please fix them. And could you please update the Changelog? (Unreleased->New section)

pkg/scalers/selenium_grid_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/selenium_grid_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/selenium_grid_scaler.go Show resolved Hide resolved
pkg/scalers/selenium_grid_scaler.go Show resolved Hide resolved
prashanth-volvocars and others added 4 commits July 27, 2021 14:48
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
@zroubalik zroubalik added this to the v2.4.0 milestone Jul 27, 2021
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 337bc0f into kedacore:main Jul 31, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Scaler for Selenium Grid
3 participants