-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Selenium Grid scaler #1971
Add Selenium Grid scaler #1971
Conversation
Signed-off-by: prashanth <rprashanth27@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution! Looking good, there are a couple of minor nits and some linting problems. Could you please fix them. And could you please update the Changelog? (Unreleased->New section)
8296c73
to
2c982b4
Compare
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: prashanth <rprashanth27@gmail.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
Signed-off-by: prashanth <rprashanth27@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: prashanth <rprashanth27@gmail.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Signed-off-by: prashanth rprashanth27@gmail.com
Added a new scaler to scale selenium grid browser nodes based on the requests pending in queue. This will query the selenium grid based on the url that user provides and determine the metric based on the provided browser name.
Checklist
Fixes #871