Use scaled[object/job].keda.sh/ prefix for KEDA related labels
#2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
changed the title
scaled[object/job].keda.sh/ prefix for KEDA related labels
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
As always! |
🤦♂️
TsuyoshiUshio
pushed a commit
that referenced
this pull request
Aug 6, 2021
Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
…acore#2008) Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
KEDA defines and uses labels in order to do scaling, there are certain recommendations for labels naming, ie. use some prefix and keep non prefixed for user defined labels.
https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/
Also:
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
So this PR intoduces a change in labels (It shouldn't bring any problems to users as KEDA Operator automatically sets these):
ScaledObject:
scaledObjectName->scaledobject.keda.sh/nameScaleJob:
scaledJob->scaledjob.keda.sh/nameChecklist