Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsafeSsl parameter on InfluxDB #2157

Merged
merged 4 commits into from
Oct 7, 2021

Conversation

dtsioumas
Copy link
Contributor

@dtsioumas dtsioumas commented Oct 5, 2021

Signed-off-by: Dimitrios Tsioumas dtsioumas@protonmail.com

Adds unsafeSsL parameter in the InfluxDB scaler, usnafeSsl disables SSL certificate verification. Use when connecting over HTTPS with a self-signed certificate.

Checklist

Fixes #2124

@JorTurFer
Copy link
Member

Could you sign your latest commit?
https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

There are another 2 errors related with the linting. Could you take a look at them?
https://github.com/kedacore/keda/runs/3805290932

Thanks :)

pkg/scalers/influxdb_scaler.go Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

Would you mind updating Changelog (Improvements section), please?

Signed-off-by: Dimitris Tsioumas <dtsioumas@protonmail.com>
@dtsioumas dtsioumas force-pushed the influxdb-unsafeSsl-parameter branch from e984aca to 83c61c3 Compare October 7, 2021 13:22
Signed-off-by: Dimitris Tsioumas <dtsioumas@protonmail.com>
@dtsioumas dtsioumas force-pushed the influxdb-unsafeSsl-parameter branch from 3e75cd2 to 623421d Compare October 7, 2021 13:57
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@zroubalik zroubalik changed the title Add unsafeSsl parameter on influxdb Add unsafeSsl parameter on InfluxDB Oct 7, 2021
@zroubalik zroubalik merged commit 7e08fc6 into kedacore:main Oct 7, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Signed-off-by: Dimitris Tsioumas <dtsioumas@protonmail.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unsafeSsL parameter on InfluxDB scaler
3 participants