Add pageSize (using regex) in RabbitMQ Scaler #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
1 task
|
Could you trigger again the CI? |
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jorturfer jorge_turrado@hotmail.es
After discussed it in this PR about if RabbitMQ should support pagination browsing (using regex), we decided to don't support it but add an extra parameter to support setting the page size.
This PR adds support to the
pageSizevalue in order to bring the option to increase from 100 (default value in RabbitMQ).Checklist
pageSizeparameter in RabbitMQ Scaler keda-docs#546Fixes #2068