Propagate contexts down scaler call stacks #2202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins to propagate
context.Context
s down the call stacks of various scalers.Checklist
Commits are signed with Developer Certificate of Origin (DCO - learn more)
Tests have been added
Update all
http.NewRequest()
calls tohttp.NewRequestWithContext()
Update calls to functions in the
redis-go
module to use contexts passed from callers, rather than justcontext.Background()
Update calls to PostgreSQL/MySQL/MSSQL Scaler (due to SQL's QueryRowContext) to contexts passed from callers
Same as ^^ but for MongoDB
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)(N/A)A PR is opened to update the documentation on (repo) (if applicable)(N/A)Changelog has been updated
Partially addresses #2190