-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate contexts down scaler call stacks #2202
Conversation
Signed-off-by: Aaron <aaron@ecomaz.net>
Signed-off-by: Aaron <aaron@ecomaz.net>
Nice job! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks for doing this :)
Signed-off-by: Aaron <aaron@ecomaz.net>
Signed-off-by: Aaron <aaron@ecomaz.net>
…dding context to scaler Close interface Signed-off-by: Aaron <aaron@ecomaz.net>
Signed-off-by: Aaron <aaron@ecomaz.net>
Signed-off-by: Aaron <aaron@ecomaz.net>
Signed-off-by: Aaron <aaron@ecomaz.net>
@zroubalik @JorTurFer I believe this PR is ready for reviews, so I've moved it out of draft mode. the changes are large when measured by number of files changed, but relatively small when measured by lines changed. that's because it's a largely mechanical change that ensures that can you take a look when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just minor nit in Changelog.
Signed-off-by: Aaron <aaron@ecomaz.net>
This PR begins to propagate
context.Context
s down the call stacks of various scalers.Checklist
Commits are signed with Developer Certificate of Origin (DCO - learn more)
Tests have been added
Update all
http.NewRequest()
calls tohttp.NewRequestWithContext()
Update calls to functions in the
redis-go
module to use contexts passed from callers, rather than justcontext.Background()
Update calls to PostgreSQL/MySQL/MSSQL Scaler (due to SQL's QueryRowContext) to contexts passed from callers
Same as ^^ but for MongoDB
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)(N/A)A PR is opened to update the documentation on (repo) (if applicable)(N/A)Changelog has been updated
Partially addresses #2190