Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cassandra scaler and tests #2211

Merged
merged 4 commits into from
Oct 27, 2021
Merged

Add Cassandra scaler and tests #2211

merged 4 commits into from
Oct 27, 2021

Conversation

nilayasiktoprak
Copy link
Contributor

@nilayasiktoprak nilayasiktoprak commented Oct 25, 2021 •
edited by zroubalik
Loading

Signed-off-by: nilayasiktoprak nilayasiktoprak@gmail.com

Add Cassandra scaler, e2e test and unit test.

Checklist

Fixes #1738

@nilayasiktoprak
Add Cassandra scaler and tests
358a6f0 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@tomkerkhove
Copy link
Member

Are these docs still up-to-date? kedacore/keda-docs#452

@nilayasiktoprak
Copy link
Contributor Author

No but I have the updated version in my local, just did not send it yet. I can send it now

@nilayasiktoprak nilayasiktoprak mentioned this pull request Oct 25, 2021
Merged
1 task
zroubalik
zroubalik reviewed Oct 25, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just a minor nit on context propagation.

pkg/scalers/cassandra_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/cassandra_scaler.go Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

@nilayasiktoprak and please don't forget to update Changelog (Unreleased->New section)

@nilayasiktoprak
Add scalerIndex
c2c83c4 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Update CHANGELOG.md
82ef70f 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik zroubalik added this to the v2.5.0 milestone Oct 27, 2021
@zroubalik
Copy link
Member

@JorTurFer PTAL

JorTurFer
JorTurFer approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(I have never used cassandra so I can't say anything apart from code and naming)

EDIT: Of course, thanks for your contribution! ❤️

@zroubalik zroubalik merged commit cfb18c5 into kedacore:main Oct 27, 2021
@zroubalik
Copy link
Member

@nilayasiktoprak thanks for the contribution!

@zroubalik zroubalik mentioned this pull request Oct 27, 2021
Merged
1 task
@tomkerkhove
Copy link
Member

Thanks a ton @nilayasiktoprak! 🎉

@nilayasiktoprak nilayasiktoprak deleted the cassandra branch October 29, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@arschles arschles Awaiting requested review from arschles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

Provide scaler for Cassandra
4 participants
@nilayasiktoprak @tomkerkhove @zroubalik @JorTurFer