Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triggering condition to failure reaction for on-demand command #2257

Merged
merged 2 commits into from
Nov 6, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Nov 5, 2021

Signed-off-by: jorturfer jorge_turrado@hotmail.es

After merged, the new workflow, all the comment on PRs are reacted with 👎 always that e2e are not successfully passed, even if they should not be executed.
This is an example

The workflow only should react to authorized comments

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

/run-e2e cron*

@JorTurFer
Copy link
Member Author

Sorry, I couldn't not try it xD

@zroubalik
Copy link
Member

/run-e2e cron*

@zroubalik zroubalik merged commit af17aad into kedacore:main Nov 6, 2021
@JorTurFer JorTurFer deleted the add_condition branch November 6, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants