Propagating contexts to all remaining scalers #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
…tack Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
|
/run-e2e |
|
@arschles I do not have a very deep understanding of KEDA's codebase, but LGTM :) |
zroubalik
approved these changes
Nov 10, 2021
@jerbob92 not a problem, and thank you for looking
@zroubalik my pleasure. thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2022 and then again in #2187, work was done to propagate
context.Contextvalues down most call stacks, terminating in scaler logic. Now that #2187 is merged, this PR completes that work. Most of the changes herein are mechanical, addingcontext.Contextto function signatures and passing the incoming parameter to functions as necessary. This PR removes all remaining uses ofcontext.TODO()andcontext.Background()in non-test code in favor of a context from the caller. Root contexts (from themainfunction) come from the controller-runtime signal handler.Checklist
Tests have been addedA PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)(N/A)A PR is opened to update the documentation on (repo) (if applicable)(N/A)Fixes #2190
@jerbob92 can you take a look at this PR? I think I addressed all of the changes that you are looking for, but I'd like to make sure.