Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Relic variables for e2e tests #2390

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Dec 7, 2021

Signed-off-by: jorturfer jorge_turrado@hotmail.es

In order to be able to test this PR, New Relic environment variables are needed, otherwise the pr-e2e workflow will fail because it gets the definition from main branch.
Those variables are already defined inside repo secrets

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner December 7, 2021 17:09
@zroubalik zroubalik merged commit 4a1e358 into kedacore:main Dec 7, 2021
@JorTurFer JorTurFer deleted the add_nr_var_e2e branch January 11, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants