fail fast on buildScalers when not able to resolve a secret
#2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e |
JorTurFer
requested changes
Dec 8, 2021
zroubalik
reviewed
Dec 8, 2021
fivesheep
force-pushed
the
fail-fast-on-scaler-creation
branch
from
5a8a213 to
1925b06
Compare
Signed-off-by: Xiayang Wu <xwu@rippling.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Xiayang Wu <xwu@rippling.com>
Signed-off-by: Xiayang Wu <xwu@rippling.com>
fivesheep
force-pushed
the
fail-fast-on-scaler-creation
branch
from
1925b06 to
05a891a
Compare
|
@JorTurFer sorry, I totally forgot about this PR because of holiday. changelog is updated alongside the code suggestion |
JorTurFer
approved these changes
Jan 16, 2022
|
/run-e2e mongo* |
zroubalik
changed the title
buildScalers when not able to resolve a secret
zroubalik
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiayang Wu xwu@rippling.com
Instead of creating an unexpected HPA, fail fast when not able to resolve a secret a deployment is relying on.
the missing secret can be a mistake or just timing issue. more details can be found from #2393
Checklist
Fixes #2393