Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add list and watch access for service accounts to cluster role #2410

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Dec 20, 2021

Signed-off-by: Jorge Turrado jorge.turrado@docplanner.com

This PR fixes the missing changes in this

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #2383

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer JorTurFer requested a review from zroubalik December 20, 2021 09:02
@JorTurFer JorTurFer requested a review from a team as a code owner December 20, 2021 09:02
Jorge Turrado added 2 commits December 20, 2021 10:03
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer JorTurFer merged commit dfcae51 into kedacore:main Dec 20, 2021
@JorTurFer JorTurFer deleted the fix_rbac branch December 20, 2021 09:47
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Jan 4, 2022
…edacore#2410)

* fix: add list and watch access for service accounts to cluster role

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>

* Update changelog

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
zroubalik pushed a commit that referenced this pull request Jan 4, 2022
…2410)

* fix: add list and watch access for service accounts to cluster role

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>

* Update changelog

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
alex60217101990 pushed a commit to dysnix/keda that referenced this pull request Jan 10, 2022
…edacore#2410)

* fix: add list and watch access for service accounts to cluster role

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>

* Update changelog

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: alex60217101990 <alex6021710@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does keda-operator ClusterRole need access to serviceaccounts?
2 participants