Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically release container image for ARM #2457

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Automatically release container image for ARM #2457

merged 3 commits into from
Mar 1, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 10, 2022 •
edited
Loading

This PR adds (using buildx and cross compilation) support for ARM arch (https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/)
Also removes the support to dockerhub

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #2263

@JorTurFer JorTurFer force-pushed the arm branch 4 times, most recently from 19fafe3 to f95c3a8 Compare January 11, 2022 14:45
@JorTurFer JorTurFer marked this pull request as ready for review January 11, 2022 22:07
@JorTurFer JorTurFer requested a review from a team as a code owner January 11, 2022 22:07
zroubalik
zroubalik reviewed Jan 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/main-build.yml Show resolved Hide resolved
@zroubalik zroubalik added this to the v2.6.0 milestone Jan 12, 2022
@JorTurFer JorTurFer force-pushed the arm branch 3 times, most recently from 08449d0 to 22eb7d1 Compare January 13, 2022 13:05
@JorTurFer JorTurFer requested a review from zroubalik January 13, 2022 13:06
@zroubalik zroubalik modified the milestones: v2.6.0, 2.7.0, v2.7.0 Jan 21, 2022
@JorTurFer JorTurFer force-pushed the arm branch 2 times, most recently from dce7ecc to 11d358b Compare January 21, 2022 17:12
zroubalik
zroubalik approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JorTurFer are we going to merge this one and give it a try?

@JorTurFer
Copy link
Member Author

@JorTurFer are we going to merge this one and give it a try?

Sure, during this week I'll update the PR

JorTurFer and others added 3 commits March 1, 2022 12:59
@JorTurFer
Automatically release container image for ARM
7427309 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Remove whitespaces
986cfc2 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Update changelog to use the issue
f420dd7 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer merged commit be8ed97 into kedacore:main Mar 1, 2022
@JorTurFer JorTurFer deleted the arm branch March 1, 2022 12:39
@JorTurFer JorTurFer self-assigned this Mar 1, 2022
@JatinSanghvi JatinSanghvi mentioned this pull request May 10, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees

@JorTurFer JorTurFer

Labels
None yet
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

Automatically release container image for ARM
2 participants
@JorTurFer @zroubalik