-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all resources are deleted after the tests and reorganize env names #2670
Conversation
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
03393fd
to
01f58b8
Compare
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
/run-e2e |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
/run-e2e |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Namespaces might be created via yaml:
keda/tests/scalers/influxdb.test.ts
Line 129 in b6bc7b7
kind: Namespace |
Nice catch, I'll update them too |
I haven't check that properly, so there might be another occurencies. |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
It seems that it was the only occurrence 😄 |
/run-e2e influx* |
🤦 |
Signed-off-by: Jorge Turrado jorge.turrado@docplanner.com
The main idea of how this works, is that every e2e namespaces are labelled with
type=e2e
so we can delete them at once always after e2e execution. This is a security mechanism and not a reason to don't clean test resources inside test scope.Apart from that, some environment variables have been renamed.
Extra point: Azure queue e2e tests now wait till the queue is created to continue because there are some cases where the test follows without the queue and fails
Checklist
Fixes #2584