Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all resources are deleted after the tests and reorganize env names #2670

Merged
merged 16 commits into from
Feb 28, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Feb 24, 2022

Signed-off-by: Jorge Turrado jorge.turrado@docplanner.com

The main idea of how this works, is that every e2e namespaces are labelled with type=e2e so we can delete them at once always after e2e execution. This is a security mechanism and not a reason to don't clean test resources inside test scope.
Apart from that, some environment variables have been renamed.

Extra point: Azure queue e2e tests now wait till the queue is created to continue because there are some cases where the test follows without the queue and fails

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2584

Jorge Turrado and others added 10 commits February 28, 2022 10:31
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 28, 2022

/run-e2e
Update: You can check the progres here

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 28, 2022

/run-e2e
Update: You can check the progres here

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title WIP - Ensure all resources are deleted after the tests and reorganize env names Ensure all resources are deleted after the tests and reorganize env names Feb 28, 2022
@JorTurFer JorTurFer marked this pull request as ready for review February 28, 2022 15:31
@JorTurFer JorTurFer requested a review from a team as a code owner February 28, 2022 15:31
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Namespaces might be created via yaml:

kind: Namespace

@JorTurFer
Copy link
Member Author

Some Namespaces might be created via yaml:

kind: Namespace

Nice catch, I'll update them too

@zroubalik
Copy link
Member

Some Namespaces might be created via yaml:

kind: Namespace

Nice catch, I'll update them too

I haven't check that properly, so there might be another occurencies.

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

Some Namespaces might be created via yaml:

kind: Namespace

Nice catch, I'll update them too

I haven't check that properly, so there might be another occurencies.

It seems that it was the only occurrence 😄

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 28, 2022

/run-e2e influx*
Update: You can check the progres here

@zroubalik zroubalik merged commit 3f82ca8 into kedacore:main Feb 28, 2022
@JorTurFer JorTurFer deleted the clean-resources branch February 28, 2022 18:44
@zroubalik
Copy link
Member

@JorTurFer
Copy link
Member Author

🤦
We should only clean if the context is recovered. Let me check how to solve it
BTW, I forgot to say it but we had to wait till @tomkerkhove adds 2 secrets. App insights e2e test will fail till they are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve e2e tests to always cleanup resources in cluster
2 participants