fix: Consider maxSessions in Selenium Grid Scaler #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Dominguez <adborroto90@gmail.com>
Signed-off-by: Alejandro Dominguez <adborroto90@gmail.com>
1 task
adborroto
changed the title
|
/run-e2e selenium* |
JorTurFer
reviewed
Mar 21, 2022
|
/run-e2e selenium* |
JorTurFer
approved these changes
Mar 22, 2022
RamCohen
pushed a commit
to RamCohen/keda
that referenced
this pull request
Mar 23, 2022
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alejandro Dominguez adborroto90@gmail.com
Consider grid
maxSessionto scale Selenium Grid. Since each node can handle a number of parallel sessions defined bymaxSessionthen is not needed to scale for each pending session.Example: if maxSession=5 each node can hold up to 5 concurrent sessions. Therefore, if there are 10 requests in the queue, only 2 nodes are necessary to fulfill the requirements. Currently, the Selenium Grid Scaler of KEDA will scale up to 10 nodes in this case, ignoring the maxSessions per node.
Documentation changes: PR
More info:
Checklist
Fixes #2618