Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean go.mod to fix golangci-lint #2782

Merged
merged 3 commits into from
Mar 22, 2022
Merged

fix: clean go.mod to fix golangci-lint #2782

merged 3 commits into from
Mar 22, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Mar 21, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2783

@JorTurFer
fix: Clean go.mod to fix golangci-lint
34640cc 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner March 21, 2022 20:07
@JorTurFer JorTurFer changed the title fix: Clean go.mod to fix golangci-lint fix: clean go.mod to fix golangci-lint Mar 21, 2022
@JorTurFer
fix style error
051f0bc 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Update changelog
cf873a0 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@zroubalik zroubalik merged commit bb113fb into kedacore:main Mar 22, 2022
@JorTurFer JorTurFer deleted the fix-ci branch March 22, 2022 07:36
RamCohen pushed a commit to RamCohen/keda that referenced this pull request Mar 23, 2022
@RamCohen
fix: clean go.mod to fix golangci-lint (kedacore#2782)
29ae2a1 
* fix: Clean go.mod to fix golangci-lint

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* fix style error

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Update changelog

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI workflow is failing (static checks)
2 participants
@JorTurFer @zroubalik