Non-public cloud support for Azure Key Vault.

[v-shenoy]

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Azure Key Vault now supports non-public clouds via the cloud parameter.

Sample TriggerAuthentication definition with keyvault.

apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: triggerauth-name
  namespace: default
spec:
  azureKeyVault:
    vaultUri: <vault-uri>
    credentials:  
      clientId: <active-directory-client-id>
      clientSecret:
        valueFrom:
          secretKeyRef:
            name: <secret-containing-client-password>
            key: <key-within-secret>
      tenantId: <active-directory-tenant-id>
    cloud: # Optional
      type: private # Required
      keyVaultResourceURL: <key-vault-resource-url-for-cloud> # Required when type = private
      activeDirectoryEndpoint: <active-directory-endpoint-for-cloud> # Required when type = private
    secrets: 
    - parameter: <param-name-for-scaled-object>
      name: <secret-name-in-key-vault>

Documentation PR - kedacore/keda-docs#732

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• Tests have been added
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Changelog has been updated and is aligned with our changelog requirements

Relates to #2733

[tomkerkhove]

Might be good to align the cloud information with scalers maybe?

What about this?

-cloudInfo: # Optional
+cloud:
  type: private # Required
-  keyVaultResourceURL: <key-vault-resource-url-for-cloud> # Required when type = private
+  keyVaultResourceUri: <key-vault-resource-url-for-cloud> # Required when type = private
-  activeDirectoryEndpoint: <active-directory-endpoint-for-cloud> # Required when type = private
+  activeDirectoryUri: <active-directory-endpoint-for-cloud> # Required when type = private

[tomkerkhove]

Can you open a PR for our docs and link it in this PR please? This is why I tend to use "relates to" instead of "fixes" as we always need a link without closing on this PR.

[v-shenoy]

Can you open a PR for our docs and link it in this PR please? This is why I tend to use "relates to" instead of "fixes" as we always need a link without closing on this PR.

Was away for some time, am writing the docs as we speak. I don't get the second part of your comment, can you elaborate a bit?

[v-shenoy]

Doc PR - kedacore/keda-docs#732

[v-shenoy]

Changed cloudInfo to cloud

Didn't change the keyVaultResourceURL and activeDirectoryEndpoint as the names align with the changes done for EventHub and Application Insights.

@tomkerkhove

[tomkerkhove]

Fine by me!

[tomkerkhove]

Can you open a PR for our docs and link it in this PR please? This is why I tend to use "relates to" instead of "fixes" as we always need a link without closing on this PR.

Was away for some time, am writing the docs as we speak. I don't get the second part of your comment, can you elaborate a bit?

Neermind the second part!

[zroubalik]

LGTM

[JorTurFer]

LGTM

[JorTurFer]

Thanks for this improvement! ❤️