Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-public cloud support for Azure Monitor scaler. #2837

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

v-shenoy
Copy link
Contributor

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Supporting non-public clouds for the Azure Monitor scaler using the cloud parameter.

Sample ScaledObject definition -

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: monitor-so
spec:
  scaleTargetRef: 
    name: monitor-deployment
  pollingInterval: 10
  cooldownPeriod: 30
  minReplicaCount: 0
  maxReplicaCount: 2
  triggers:
    - type: azure-monitor
      metadata:
        resourceURI: <resource-uri>
        tenantId: <tenant-id>
        subscriptionId: <subscription-id>
        resourceGroupName: <rg-name>
        targetValue: <target>
        metricName: <metric-name>
        metricAggregationType: <metric-agg-type>
        cloud: "private" 
        resourceManagerEndpoint: <resource-manager-endpoint>
        activeDirectoryEndpoint: <active-directory-endpoint>
      authenticationRef:
        name: monitor-ta

Documentation PR - kedacore/keda-docs#735

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #1917

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy v-shenoy requested a review from a team as a code owner March 28, 2022 12:33
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Some comments inline

pkg/scalers/azure_monitor_scaler.go Show resolved Hide resolved
pkg/scalers/azure_monitor_scaler.go Show resolved Hide resolved
pkg/scalers/azure_monitor_scaler.go Show resolved Hide resolved
@JorTurFer JorTurFer merged commit bb276f6 into kedacore:main Mar 29, 2022
@v-shenoy v-shenoy deleted the npc-monitor branch March 29, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support non-public clouds for Azure Monitor
2 participants