Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add globPattern, recursive parameters to Azure Blob Storage Scaler. #2846

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Add globPattern, recursive parameters to Azure Blob Storage Scaler. #2846

merged 3 commits into from
Apr 1, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Mar 30, 2022 •
edited
Loading

Sample ScaledObject spec -

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: blob-so
spec:
  scaleTargetRef: 
    name: blob-deployment
  pollingInterval: 10
  cooldownPeriod: 30
  minReplicaCount: 0
  maxReplicaCount: 2
  triggers:
    - type: azure-blob
      metadata:
        blobContainerName: keda
        metricName: keda
        globPattern: foo**
        recursive: "true"
      authenticationRef:
        name: blob-ta

Documentation PR - kedacore/keda-docs#738

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #1789

@v-shenoy v-shenoy requested a review from a team as a code owner March 30, 2022 13:31
v-shenoy added 3 commits March 30, 2022 23:20
@v-shenoy
Refactor Azure Blob Scaler code.
61cb731 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Add globPattern, recursive parameters to Azure Blob Storage Scaler.
dd906ee 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Add unit tests.
533fa81 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@zroubalik
Copy link
Member

@tomkerkhove PTAL

tomkerkhove
tomkerkhove approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not a Go expert

@zroubalik
Copy link
Member

LGTM, but not a Go expert

It's more like whether it solves the issue. We discussed this on the call and weren't 100% about the desired behavior.

@tomkerkhove tomkerkhove merged commit 424bbc0 into kedacore:main Apr 1, 2022
@v-shenoy v-shenoy deleted the rec-blob branch April 1, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Blob Storage Scaler doesn't list blobs recursively
3 participants
@v-shenoy @zroubalik @tomkerkhove