Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for Azure Service Bus scaler. #2882

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Add e2e tests for Azure Service Bus scaler. #2882

merged 2 commits into from
Apr 20, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Apr 5, 2022 •
edited
Loading

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

E2E Tests for Azure Service Bus scaler (Topic and Queue).

Requires AZURE_SERVICE_BUS_CONNECTION_STRING environment variable.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2731
Fixes #2732

@v-shenoy v-shenoy requested a review from a team as a code owner April 5, 2022 11:07
@JorTurFer
Copy link
Member

@tomkerkhove , Could you add the needed secrets? 🙏

JorTurFer
JorTurFer reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's wait till secrets are ready to execute the test

@v-shenoy
Copy link
Contributor Author

@tomkerkhove Any update here?

@JorTurFer JorTurFer assigned JorTurFer and tomkerkhove and unassigned JorTurFer Apr 20, 2022
@tomkerkhove
Copy link
Member

On it. Would you mind fixing the conflicts in meantime @v-shenoy?

@tomkerkhove tomkerkhove mentioned this pull request Apr 20, 2022
Merged
5 tasks
@tomkerkhove
Copy link
Member

Done #2925

@JorTurFer
Copy link
Member

JorTurFer commented Apr 20, 2022 •
edited by github-actions bot
Loading

/run-e2e azure-service-bus*
Update: You can check the progres here

JorTurFer
JorTurFer approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please, rebase main into your branch 🙏

v-shenoy added 2 commits April 20, 2022 20:59
@v-shenoy
Add e2e tests for Azure Service Bus scaler.
2758da0 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Fix minor error in comments.
5563a5a 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Copy link
Contributor Author

Done. @JorTurFer @tomkerkhove

@zroubalik
Copy link
Member

zroubalik commented Apr 20, 2022 •
edited by github-actions bot
Loading

/run-e2e azure-service-bus*
Update: You can check the progres here

@JorTurFer JorTurFer merged commit 501098e into kedacore:main Apr 20, 2022
@JorTurFer
Copy link
Member

Thanks for the improvement!!!

@v-shenoy v-shenoy deleted the service-bus-e2e branch April 20, 2022 17:19
bamboo12366 pushed a commit to bamboo12366/keda that referenced this pull request Apr 30, 2022
@v-shenoy @bamboo12366
Add e2e tests for Azure Service Bus scaler. (kedacore#2882)
47e6f7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees

@tomkerkhove tomkerkhove

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e test for Azure Service Bus scaler (Queue) Add e2e test for Azure Service Bus scaler (Topic)
4 participants
@v-shenoy @JorTurFer @tomkerkhove @zroubalik