Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve e2e tests reliability #2942

Merged
merged 11 commits into from
Apr 28, 2022
Merged

feat: improve e2e tests reliability #2942

merged 11 commits into from
Apr 28, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Apr 27, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Summary of changes:

  • argo-rollouts e2e test used outdated manifest and that's why it fails:
    image

  • Small improvements in mysql

  • Small improvements in postgresql

  • Redis e2e tests don't use pvc any more (slow responses sometimes provisioning them produces timeout on tests)

  • Influxdb e2e test doesn't use pvc any more (slow responses sometimes provisioning them produces timeout on test)

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

@JorTurFer
update argocd manifest version because it uses deprecated versions
476fefe 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 27, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
update mysql test values
883a7c3 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 27, 2022 •
edited by github-actions bot
Loading

/run-e2e mysql*
Update: You can check the progres here

@JorTurFer JorTurFer marked this pull request as ready for review April 27, 2022 22:52
@JorTurFer JorTurFer requested a review from a team as a code owner April 27, 2022 22:52
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 27, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 27, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 28, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
not use persistance in redis sentinel
0382478 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 28, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
not use persistance for influxdb e2e test
db58e08 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
replace bitnami redis cluster with a helper to avoid pv
21a6c6a 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 28, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
adjust mysql e2e test
d4902d1 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 28, 2022 •
edited by github-actions bot
Loading

/run-e2e sql
Update: You can check the progres here

@JorTurFer
adjust pending messages after fixing image
e50feac 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 28, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

zroubalik
zroubalik approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 28, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
adjust timeouts
03cfb1c 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Merge branch 'improve-e2e' of github.com:JorTurFer/keda into improve-e2e
e2c4c84
@JorTurFer
adjust postgresql parameters
b80b2ac 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 28, 2022 •
edited by github-actions bot
Loading

/run-e2e sql
Update: You can check the progres here

@JorTurFer
adjust postgresql parameters
e584519 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 28, 2022 •
edited by github-actions bot
Loading

/run-e2e sql
Update: You can check the progres here

@JorTurFer JorTurFer merged commit 71a2ff9 into kedacore:main Apr 28, 2022
@JorTurFer JorTurFer deleted the improve-e2e branch April 28, 2022 20:55
@JorTurFer JorTurFer mentioned this pull request Apr 28, 2022
Merged
2 tasks
bamboo12366 pushed a commit to bamboo12366/keda that referenced this pull request Apr 30, 2022
@bamboo12366
feat: improve e2e tests reliability (kedacore#2942)
5d1a61c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorTurFer @zroubalik @tomkerkhove