Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use mili scale to support more precision #3125

Merged
merged 17 commits into from
Jun 14, 2022
Merged

feat: Use mili scale to support more precision #3125

merged 17 commits into from
Jun 14, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jun 5, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3135

Relates to #

@JorTurFer
add 'A' scalers
c91b7c9 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 5, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progres here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 5, 2022 •
edited by github-actions bot
Loading

/run-e2e aws*
Update: You can check the progres here

@JorTurFer
add 'E' scalers
2e3ee10 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
add 'G' scalers
875a831 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
add 'M' scalers
ae2e31b 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 5, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 6, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
fix error in metrics api
aef8f3c 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
add 'P' scalers
ce0aac0 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
update gitignore
49a4621 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Add all the scalers
6531b85 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
apply pre-commit
54440c7 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 6, 2022 •
edited by github-actions bot
Loading

/run-e2e mongo*
Update: You can check the progres here

@JorTurFer
undo changes in cassandra scaler
8d3f6c6 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
update e2e
4d6385e 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
reverted changes in gcp scalers
f8acccf 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 6, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@tomkerkhove
Copy link
Member

Can you create an issue or provide a description so that it's clear what this is about please?

@tomkerkhove
Copy link
Member

Thank you @JorTurFer!

@JorTurFer
Copy link
Member Author

Thank you @JorTurFer!

yw, I should create it before starting... I'll try to do it better next time

@JorTurFer JorTurFer requested review from a team and removed request for a team June 7, 2022 09:42
@JorTurFer
use float64 for ScaledJob calculations
c1a4964 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 7, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
undo e2e test changes
77e807c 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix tests
7724db2 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer marked this pull request as ready for review June 8, 2022 06:34
@JorTurFer JorTurFer requested a review from a team as a code owner June 8, 2022 06:34
@JorTurFer JorTurFer marked this pull request as draft June 8, 2022 06:34
@JorTurFer JorTurFer removed the request for review from a team June 8, 2022 06:34
@JorTurFer
update changelog
98994f1 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer marked this pull request as ready for review June 8, 2022 21:27
@JorTurFer JorTurFer changed the title WIP - feat: Use mili scale to support more precision feat: Use mili scale to support more precision Jun 8, 2022
@JorTurFer JorTurFer requested a review from a team June 8, 2022 21:29
@JorTurFer
fix typo
c7080bf 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 8, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

zroubalik
zroubalik approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JorTurFer JorTurFer merged commit 2698fe1 into kedacore:main Jun 14, 2022
@JorTurFer JorTurFer deleted the use-mili branch June 14, 2022 18:08
aviadlevy pushed a commit to aviadlevy/keda that referenced this pull request Jun 16, 2022
@aviadlevy
feat: Use mili scale to support more precision (kedacore#3125)
1c57a93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use mili scale to support more precision
3 participants
@JorTurFer @tomkerkhove @zroubalik