Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce activationThreshold/minMetricValue for ActiveMQ Scaler #3339

Merged
merged 11 commits into from
Jul 11, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jul 8, 2022

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Checklist

Relates to #2800
Relates to kedacore/keda-docs#806
Fixes #3224

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner July 8, 2022 01:05
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 8, 2022

/run-e2e activemq*
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) July 8, 2022 01:07
@tomkerkhove
Copy link
Member

Can you update the docs please?

@JorTurFer
Copy link
Member Author

Can you update the docs please?

Yes, I left if for today :)

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 8, 2022

/run-e2e active*
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 8, 2022

/run-e2e activemq*
Update: You can check the progress here

JorTurFer and others added 5 commits July 8, 2022 21:20
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 8, 2022

/run-e2e activemq*
Update: You can check the progress here

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/activemq_scaler.go Outdated Show resolved Hide resolved
tests/helper/helper.go Outdated Show resolved Hide resolved
Jorge Turrado added 2 commits July 11, 2022 08:31
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022

/run-e2e activemq
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 6318652 into kedacore:main Jul 11, 2022
@JorTurFer JorTurFer deleted the activation-threshold-1 branch July 11, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for ActiveMQ to Go
2 participants