Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate e2e test for MySQL Scaler to Go #3343

Merged
merged 3 commits into from
Jul 9, 2022
Merged

Migrate e2e test for MySQL Scaler to Go #3343

merged 3 commits into from
Jul 9, 2022

Conversation

yokawasa
Copy link
Contributor

@yokawasa yokawasa commented Jul 9, 2022

Added Golang based e2e test for MySQL Scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added

Fixes #3243

yokawasa added 2 commits July 9, 2022 13:41
@yokawasa
Added Go based e2e test for mySQL Scaler
8a3b00c 
Signed-off-by: Yoichi Kawasaki <yokawasa@gmail.com>
@yokawasa
remove TypeScript based e2e test for mySQL Scaler
02abd6d 
Signed-off-by: Yoichi Kawasaki <yokawasa@gmail.com>
@yokawasa yokawasa requested a review from a team as a code owner July 9, 2022 04:46
@yokawasa
fix unnecessary conversion
1d4b50b 
Signed-off-by: Yoichi Kawasaki <yokawasa@gmail.com>
JorTurFer
JorTurFer approved these changes Jul 9, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JorTurFer
Copy link
Member

JorTurFer commented Jul 9, 2022 •
edited by github-actions bot
Loading

/run-e2e mysql
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) July 9, 2022 10:48
@JorTurFer JorTurFer merged commit 2c2237f into kedacore:main Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for MySQL to Go
2 participants
@yokawasa @JorTurFer