Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce annotation for ScaledJobs to explicitly pause autoscaling #3357

Conversation

keegancwinchester
Copy link

@keegancwinchester keegancwinchester commented Jul 12, 2022

Introduce annotation for ScaledJobs to explicitly pause autoscaling so that new jobs are no longer spun up

Signed-off-by: keeganwinchester-shipt 91917907+keeganwinchester-shipt@users.noreply.github.com

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to #3303

@keegancwinchester keegancwinchester requested a review from a team as a code owner July 12, 2022 11:42
@tomkerkhove
Copy link
Member

Thanks for the PR! Would you mind opening a doc PR on kedacore/keda-docs please?

@JorTurFer
Copy link
Member

Hey,
One question, what do you want to address with that change? Adding support to pause autoscaling in ScaledJobs?

@tomkerkhove
Copy link
Member

This is for #3303, updated the PR description

@tomkerkhove
Copy link
Member

Although I think the change is not really correct though - Do you need help @keeganwinchester-shipt with some more tips on how to contribute this?

@zroubalik
Copy link
Member

@keeganwinchester-shipt any update on this please? We would like to complete this by the end of the week. So we can ship a new release the next one.

@tomkerkhove
Copy link
Member

@keeganwinchester-shipt I was wondering how things are going and if you need some help on this?

@keegancwinchester keegancwinchester force-pushed the feature/scaledjobsannotation branch from a5658dd to 4e72030 Compare September 8, 2022 12:49
@keegancwinchester keegancwinchester deleted the feature/scaledjobsannotation branch September 8, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants