Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce activationThreshold/minMetricValue for Solace Scaler #3421

Merged
merged 4 commits into from
Jul 26, 2022
Merged

feat: Introduce activationThreshold/minMetricValue for Solace Scaler #3421

merged 4 commits into from
Jul 26, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jul 25, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)

Related to #2800
Related to kedacore/keda-docs#834
Fixes #3254

@JorTurFer
feat: Introduce activationThreshold/minMetricValue for Solace Scaler
2fd9989 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner July 25, 2022 20:49
@JorTurFer JorTurFer mentioned this pull request Jul 25, 2022
Merged
1 task
@JorTurFer
adjust value for activation test
59cb92d 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 25, 2022 •
edited by github-actions bot
Loading

/run-e2e solace*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 25, 2022 •
edited by github-actions bot
Loading

/run-e2e solace*
Update: You can check the progress here

@JorTurFer
fix typo
d08fb03 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 25, 2022 •
edited by github-actions bot
Loading

/run-e2e solace*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 25, 2022 •
edited by github-actions bot
Loading

/run-e2e solace*
Update: You can check the progress here

fix quality issues
f2bd20d 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 26, 2022 •
edited by github-actions bot
Loading

/run-e2e solace*
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 17b78dd into kedacore:main Jul 26, 2022
@JorTurFer JorTurFer deleted the activation-threshold-solace branch July 26, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for Solace to Go
2 participants
@JorTurFer @zroubalik