Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce activationThreshold/minMetricValue for Predictkube Scaler #3429

Merged
merged 7 commits into from
Jul 27, 2022
Merged

feat: Introduce activationThreshold/minMetricValue for Predictkube Scaler #3429

merged 7 commits into from
Jul 27, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jul 26, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

This PR also fixes a panic in case of problems related with wrong scaler initialization

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)

Related to #2800
Related to kedacore/keda-docs#838
Fixes #3247

@JorTurFer JorTurFer requested a review from a team as a code owner July 26, 2022 23:57
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 26, 2022 •
edited by github-actions bot
Loading

/run-e2e prometheus*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 26, 2022 •
edited by github-actions bot
Loading

/run-e2e prometheus*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 27, 2022 •
edited by github-actions bot
Loading

/run-e2e predictkube*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 27, 2022 •
edited by github-actions bot
Loading

/run-e2e predictkube*
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Jul 27, 2022
Closed
1 task
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 27, 2022 •
edited by github-actions bot
Loading

/run-e2e prometheus*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 27, 2022 •
edited by github-actions bot
Loading

/run-e2e predictkube*
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Jul 27, 2022
Merged
1 task
@JorTurFer JorTurFer changed the title feat: Introduce activationThreshold/minMetricValue for Prodictkube Scaler feat: Introduce activationThreshold/minMetricValue for Predictkube Scaler Jul 27, 2022
zroubalik
zroubalik approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@JorTurFer JorTurFer enabled auto-merge (squash) July 27, 2022 11:36
@JorTurFer JorTurFer disabled auto-merge July 27, 2022 11:36
JorTurFer and others added 6 commits July 27, 2022 13:43
@JorTurFer
feat: Introduce activationThreshold/minMetricValue for Prodictkube Sc…
3b54886 
…aler

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
remove old ts file
98e4c2b 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
apply styles
23c0680 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
move prometheus helper to helper pkg
c31a7c8 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
move prometheus helper to helper pkg
1f60983 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
apply feedback
7350717 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer force-pushed the activation-threshold-predictkube branch from 52d1c60 to 7350717 Compare July 27, 2022 11:43
@JorTurFer JorTurFer enabled auto-merge (squash) July 27, 2022 11:44
@JorTurFer
fix styles
9b6b11c 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 27, 2022 •
edited by github-actions bot
Loading

/run-e2e predictkube*
Update: You can check the progress here

@JorTurFer JorTurFer merged commit df27def into kedacore:main Jul 27, 2022
@JorTurFer JorTurFer deleted the activation-threshold-predictkube branch July 27, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for PredictKube to Go
2 participants
@JorTurFer @zroubalik