Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce activationThreshold/minMetricValue for Kafka Scaler #3501

Merged
merged 6 commits into from
Aug 4, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Aug 3, 2022

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)

Related to #2800
Related to kedacore/keda-docs#865
Fixes #3238

.
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner August 3, 2022 21:35
@JorTurFer
Copy link
Member Author

JorTurFer commented Aug 3, 2022

/run-e2e kafka*
Update: You can check the progress here

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Aug 4, 2022

/run-e2e kafka*
Update: You can check the progress here

@JorTurFer JorTurFer changed the title WIP feat: Introduce activationThreshold/minMetricValue for Kafka Scaler feat: Introduce activationThreshold/minMetricValue for Kafka Scaler Aug 4, 2022
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome, thanks for doing this!

@zroubalik
Copy link
Member

@JorTurFer there are just some linter problems, the rest is looking great!

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@zroubalik
Copy link
Member

@JorTurFer there are still some linting problems

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer removed the skip-e2e label Aug 4, 2022
@JorTurFer
Copy link
Member Author

JorTurFer commented Aug 4, 2022

/run-e2e kafka*
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) August 4, 2022 13:48
@JorTurFer JorTurFer merged commit 4a4ae5f into kedacore:main Aug 4, 2022
@JorTurFer JorTurFer deleted the activation-threshold-kafka branch August 4, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for Kafka to Go
2 participants