-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce activationThreshold/minMetricValue for Kafka Scaler #3501
Conversation
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
/run-e2e kafka* |
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
/run-e2e kafka* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome, thanks for doing this!
@JorTurFer there are just some linter problems, the rest is looking great! |
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer there are still some linting problems |
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
/run-e2e kafka* |
Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es
Checklist
Related to #2800
Related to kedacore/keda-docs#865
Fixes #3238