Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete e2e test migration. #3505

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Aug 5, 2022

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added

Fixes #2737
Fixes #3435

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy v-shenoy requested a review from a team as a code owner August 5, 2022 07:18
@v-shenoy
Copy link
Contributor Author

v-shenoy commented Aug 5, 2022

/run-e2e
Update: You can check the progress here

@v-shenoy v-shenoy changed the title Migrate value metric type e2e test to Go. Complete e2e test migration. Aug 5, 2022
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Awesome job @v-shenoy ! 🚀

@zroubalik zroubalik merged commit 89c2042 into kedacore:main Aug 5, 2022
@JorTurFer
Copy link
Member

❤️❤️❤️❤️❤️

@v-shenoy v-shenoy deleted the migrate-e2e branch August 5, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for Value metricType to Go Migrate e2e tests to Go
3 participants