Add option to get queueURL from env for aws SQS scaler #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fk128
changed the title
v-shenoy
approved these changes
Aug 17, 2022
v-shenoy
suggested changes
Aug 17, 2022
There was a problem hiding this comment.
Could you modify the unit tests to include this metadata parameter?
And also raise a documentations PR in kedacore/keda-docs
1 task
v-shenoy
reviewed
Aug 18, 2022
v-shenoy
reviewed
Aug 18, 2022
tomkerkhove
reviewed
Aug 19, 2022
JorTurFer
reviewed
Sep 30, 2022
Add `queueURLFromEnv` as additional trigger metadata to allow loading the queueURL from env variables Signed-off-by: Fahdi Kanavati <fkanavati@gmail.com>
Co-authored-by: Vighnesh Shenoy <vighneshq@gmail.com> Signed-off-by: Fahdi Kanavati <fkanavati@gmail.com>
Signed-off-by: Fahdi Kanavati <fkanavati@gmail.com>
Signed-off-by: Fahdi Kanavati <fkanavati@gmail.com>
Signed-off-by: Fahdi Kanavati <fkanavati@gmail.com>
|
/run-e2e sqs* |
JorTurFer
approved these changes
Oct 21, 2022
|
Thanks for this improvement! ❤️ |
26tanishabanik
pushed a commit
to 26tanishabanik/keda
that referenced
this pull request
Nov 1, 2022
* Add option to get queueURL from env Signed-off-by: Fahdi Kanavati <fkanavati@gmail.com> Co-authored-by: Vighnesh Shenoy <vighneshq@gmail.com> Signed-off-by: 26tanishabanik <26tanishabanik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
queueURLFromEnvas additional trigger metadata to allow loading the queueURL from env variables.It would be useful to be able to set the queueURL to load from env variables, especially when having multiple deployment environment. This way if using kustomize, the queueURL could be defined in a configmap and loaded as env variable, rather than patching the manifest. This for example would be similar to the
addressFromEnvin the redis-lists scaler.Signed-off-by: Fahdi Kanavati fk128@users.noreply.github.com
Provide a description of what has been changed
Checklist
Fixes #
Relates to #
kedacore/keda-docs#902