Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics api unsafessl #3823

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Metrics api unsafessl #3823

merged 4 commits into from
Nov 4, 2022

Conversation

wymangr
Copy link
Contributor

@wymangr wymangr commented Nov 4, 2022 •
edited
Loading

Add unsafeSsl paramater to skil certificate validation when connecting over HTTPS

Checklist

  • When introducing a new scaler, I agree with the scaling governance policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3728
Fixes #3821

Relates to #972

@wymangr wymangr requested a review from a team as a code owner November 4, 2022 16:46
@wymangr wymangr mentioned this pull request Nov 4, 2022
Merged
1 task
JorTurFer
JorTurFer reviewed Nov 4, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only a suggestion inline.
We need to have all the commits signed for merging PRs (DCO check), could you sign yor commits? https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

pkg/scalers/metrics_api_scaler.go Outdated Show resolved Hide resolved
@wymangr
signing commits
a2c31ae 
Signed-off-by: Garret Wyman <garret_wyman@hotmail.com>
@wymangr wymangr force-pushed the metrics_api_unsafessl branch from 10712a9 to a2c31ae Compare November 4, 2022 18:18
JorTurFer
JorTurFer reviewed Nov 4, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@wymangr @JorTurFer
Update CHANGELOG.md
cfea60c 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Garret Wyman <garret_wyman@hotmail.com>
@JorTurFer
Copy link
Member

JorTurFer commented Nov 4, 2022 •
edited by github-actions bot
Loading

/run-e2e metrics*
Update: You can check the progress here

@wymangr
Added another test
507baaf 
Signed-off-by: Garret Wyman <garret_wyman@hotmail.com>
@zroubalik zroubalik enabled auto-merge (squash) November 4, 2022 20:49
@zroubalik
Copy link
Member

zroubalik commented Nov 4, 2022 •
edited by github-actions bot
Loading

/run-e2e metrics*
Update: You can check the progress here

@wymangr wymangr requested a review from zroubalik November 4, 2022 21:25
@zroubalik zroubalik disabled auto-merge November 4, 2022 21:27
@zroubalik zroubalik merged commit 4653241 into kedacore:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KEDA Metrics API Scaler - ability to skip tls check
3 participants
@wymangr @JorTurFer @zroubalik