Apache Pulsar: add support for bearer token and basic auth #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Nov 11, 2022
Signed-off-by: Michael Marshall <mmarshall@apache.org>
michaeljmarshall
force-pushed
the
pulsar-bearer-token
branch
from
301e744 to
6a040ec
Compare
|
@eolivelli - I knew this PR had conflicts with #3834, so I wanted to resolve those before marking this as ready. |
Signed-off-by: Michael Marshall <mmarshall@apache.org>
|
/run-e2e pulsar* |
JorTurFer
reviewed
Nov 12, 2022
Signed-off-by: Michael Marshall <mmarshall@apache.org>
Signed-off-by: Michael Marshall <mmarshall@apache.org>
|
@JorTurFer - I updated the e2e tests. |
|
/run-e2e pulsar* |
zroubalik
approved these changes
Nov 15, 2022
JorTurFer
approved these changes
Nov 15, 2022
|
we have merged this feature without merging the docs PR kedacore/keda-docs#977 xD |
|
@JorTurFer 🤦 sorry |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Marshall mmarshall@apache.org
Modifications
This PR adds support for both bearer tokens and basic authentication (and authorization) with Apache Pulsar. In order to reduce duplicate code, there are some backwards compatible changes made to TLS authentication.
Note that because Apache Pulsar redirects HTTP calls using the 307 response code, it is necessary to re-add the authorization header. This PR includes that change. It is also important to add the
X-Pulsar-Auth-Method-Nameheader to make authentication calls efficient on the broker.Checklist
Fixes #3844
Relates to kedacore/keda-docs#977